Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove CSRF properties #5231

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Remove CSRF properties #5231

merged 2 commits into from
Oct 25, 2021

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 22, 2021

Description

  • make IncomingRequest::$enableCSRF deprecated
  • remove $CSRFProtection properties in Mock*Config.php

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

MGatner
MGatner approved these changes Oct 22, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@samsonasik is there any way for Rector to detect "unused properties"?

@samsonasik
Copy link
Member

@MGatner there is, only for private property to avoid bc break, and already included in dead code set list

https://github.com/rectorphp/rector-src/blob/9eac8d451ae449fa96fe811ea6d2eeffee3f182e/rules/DeadCode/Rector/Property/RemoveUnusedPrivatePropertyRector.php#L22

CodeIgniter4/rector.php

Line 53 in f43f46b

$containerConfigurator->import(SetList::DEAD_CODE);

@kenjis kenjis merged commit a9d72a7 into codeigniter4:develop Oct 25, 2021
@kenjis kenjis deleted the remove-csrf-properties branch October 25, 2021 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @samsonasik @MGatner